Fix Nokogiri parser processing xml entity encoded characters #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjarratt
added a commit
that referenced
this pull request
Sep 22, 2014
Fix Nokogiri parser processing xml entity encoded characters
Contributor
|
Thanks for submitting this pull request @tinbka. Your fix looks great -- my only concern is that we don't have any specs covering this. However, the fix looks rather harmless, so I'm willing to backfill tests at a later time. Thanks for submitting to Nori! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Nori 2.4.0 there is a bug in a parser when it processes xml entity encoded characters
that is a common case for non-English SOAP applications.
For example, if we have the next node:
and we want to convert it to hash using Nori with Nokogiri parser, it is expected to be:
but current version of Nori converts it to:
since every whitespace in source xml lies between two other nodes and looks like a non-significant crap.
The present patch fixes this case, still not touching behaviour in any other way.